Validate arrow_cast fixed-size binary length#22297
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
Conversation
Author
|
Local validation on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
arrow_cast(NULL, 'FixedSizeBinary(-1)')currently parses the type string successfully and can later panic in Arrow buffer allocation with aLayoutError. DataFusion should reject that invalid Arrow type specification before planning/simplification rewrites the function into a cast.What changes are included in this PR?
arrow_casttype parsing/validation after ArrowDataTypeparsing.FixedSizeBinaryelement lengths with a DataFusion execution error.arrow_try_castso return-field planning and simplify-time rewrites agree.List(FixedSizeBinary(-1))is rejected before it reaches execution.arrow_cast,arrow_try_cast, and nestedFixedSizeBinary(-1).Are these changes tested?
Yes.
cargo test -p datafusion-functions arrow_cast(compiled successfully; no tests matched the filter)cargo test -p datafusion-sqllogictest --test sqllogictests -- arrow_typeof.sltcargo test -p datafusion-functionscargo fmt --checkcargo clippy -p datafusion-functions --all-targets -- -D warningsgit diff --checkAre there any user-facing changes?
Yes. Invalid
FixedSizeBinary(-1)type specs passed toarrow_cast/arrow_try_castnow return a normal DataFusion execution error instead of allowing a later panic.